Specify npm version ~10 #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was previously set to ~10.4, but there is no node version that satisifed the constraint of node ~18 and npm ~10.4. This change follows the approach in the main `clients` repository.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #573 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 56 56
Lines 2552 2552
Branches 462 462
=====================================
Misses 2552 2552 ☔ View full report in Codecov by Sentry. |
|
No New Or Fixed Issues Found |
r-tome
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
The npm version was previously set to
~10.4, but there is no node/npm release that satisifed the constraint of node~18and npm~10.4.Set the
npmversion to~10. This change follows the approach in the mainclientsrepository, where we accept minor version releases of node and npm.Code changes
Screenshots
Testing requirements
Before you submit
npm run lint) (required)